This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Improve lookup props#142
Merged
Merged
Conversation
This was referenced Jan 8, 2021
Ladsgroup
approved these changes
Jan 11, 2021
We were already doing that implicitly, because the existing updateProperty action is already being called with null as the property without typescript reflecting that. This now extracts that functionality into its own action and mutation making the overall flow simpler. There are no behavioral changes in this commit.
This way, the interfaces between StringValueInput and ItemValueLookup are nicely aligned which will make the next step easier.
micgro42
force-pushed
the
extractStringValueInput
branch
from
47a5b47 to
9a7a184
Compare
It makes more sense to translate the error message only once in the EntityLookup component and not two times in the two components that use it. Also, this adds the missing disabled prop to the EntityLookup and ItemValueLookup. The PropertyLookup is never disabled and therefore doesn't need it.
micgro42
force-pushed
the
addMissingProps
branch
from
eedb41d to
ecab75f
Compare
micgro42
force-pushed
the
extractStringValueInput
branch
from
9a7a184 to
b93788f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This should be merged into master after #141 and followed by #123)
It makes more sense to translate the error message only once in the EntityLookup component and not two times in the two components that use it.
Also, this adds the missing disabled prop to the EntityLookup and ItemValueLookup. The PropertyLookup is never disabled and therefore doesn't need it.