This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Layout adjustments for the tiniest viewport#144
Merged
Conversation
micgro42
force-pushed
the
adjustTinyViewportLayout
branch
from
0273006 to
e7af0c8
Compare
guergana
previously requested changes
Jan 11, 2021
Contributor
guergana
left a comment
guergana
left a comment
There was a problem hiding this comment.
The outer spacing of the component in desktop are now gone.
Bug: T269470
micgro42
force-pushed
the
adjustTinyViewportLayout
branch
from
e7af0c8 to
8481a17
Compare
Collaborator
Author
Fixed now, I used a spacing token instead of a layout token. |
Contributor
|
I might be doing it wrong but when I pulled the branch and ran it, it still got the error in 290px: |
Collaborator
Author
Yeah. that's ok. We don't support screens below 320px. We have to stop somewhere. |
Contributor
|
Aha, I had the issue with 370px before and I thought it's the same. Missed the 100px difference. |
Ladsgroup
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be merged after #143
Inspired by the styles in https://www.figma.com/file/hZpaYX0xNNhK0L7kBvN6WK/Query-Builder?node-id=2604%3A29422
The viewport breakpoint has been chosen so that the inputs don't align as next to each other again in the smallest layout.
Also, the outer padding was too large still even for larger viewports. It should be
-small, not-xlarge.Bug: T269470