This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Adjust Value interface in RootStore by adding QuantityValue type to it#218
Merged
Adjust Value interface in RootStore by adding QuantityValue type to it#218
Conversation
guergana
force-pushed
the
QuantityValueInterface
branch
2 times, most recently
from
ca436be to
2cdd12b
Compare
guergana
force-pushed
the
QuantityValueInterface
branch
from
2cdd12b to
a2ca220
Compare
micgro42
suggested changes
Mar 11, 2021
Collaborator
micgro42
left a comment
micgro42
left a comment
There was a problem hiding this comment.
Almost there! What is missing is the ability for this type to represent a value without unit, e.g. a population 10000.
src/store/RootState.ts
Outdated
| export interface QuantityValue { | ||
| value: number; | ||
| precision?: number; | ||
| unit: ItemValue; |
Collaborator
There was a problem hiding this comment.
The unit should either be also optional or it should be nullable.
guergana
force-pushed
the
QuantityValueInterface
branch
from
a2ca220 to
bf2527c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
micgro42
approved these changes
Mar 12, 2021
Collaborator
micgro42
left a comment
micgro42
left a comment
There was a problem hiding this comment.
Looks good, thank you :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.