Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Bump version to 1.2.0-alpha.0#252

Merged
itamargiv merged 1 commit into
masterfrom
alphaLookupAndMessageRelease
Nov 4, 2020
Merged

Bump version to 1.2.0-alpha.0#252
itamargiv merged 1 commit into
masterfrom
alphaLookupAndMessageRelease

Conversation

@micgro42

@micgro42 micgro42 commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

This pre-release allows using the both Message and the Lookup component in other work-in-progress projects while still finishing up the last aspects of the Lookup component.

The Message should already be done.

https://github.com/wmde/wikit/compare/v1.1.2..alphaLookupAndMessageRelease

This allows using the both Message and the Lookup component in other
work-in-progress projects while still finishing up the last aspects of
the Lookup component.
@micgro42 micgro42 requested a review from itamargiv November 2, 2020 17:23

@Ladsgroup Ladsgroup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itamargiv

itamargiv commented Nov 3, 2020

Copy link
Copy Markdown
Member

Looks good to me, but we have an issue, as we might not be able to follow the current specified workflow (it turns out npm no longer "hides" pre-release tags since v3.4.1), see this blog post: https://medium.com/@mbostock/prereleases-and-npm-e778fc5e2420 . Which means we might need to publish this pre-release from a local computer under a different dist tag as I currently don't have time this week to work on defining a new pre release workflow, documented in task T267094.

@itamargiv itamargiv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to change. Blocking this to make sure the comment above is acknowledged.

@micgro42

micgro42 commented Nov 3, 2020

Copy link
Copy Markdown
Collaborator Author

Nothing to change. Blocking this to make sure the comment above is acknowledged.

Sorry I was in a lot of meetings and I'm still working on understanding the details here.

With "workflow" you mean an actual GitHub Workflow or an internal WMDE process?

@itamargiv

itamargiv commented Nov 3, 2020

Copy link
Copy Markdown
Member

With "workflow" you mean an actual GitHub Workflow or an internal WMDE process?

I meant both, but yeah that's too ambiguous.. What I suggest is that we team up this week and make a one off pre-realease with a dist tag from my local machine, if having this component released is as pressing as it sounds, and then it will give me time to properly think of an organized pre-release workflow (both meanings) for the future. What do you think?

@micgro42

micgro42 commented Nov 3, 2020

Copy link
Copy Markdown
Collaborator Author

Ah. I think I slightly misread the intention on the phab ticket and already started drafting one of the ADRs as I perceived them to be intended as a prerequisite for this release.

Doing this one-off pre-release this week together sounds good to me 👍

@itamargiv itamargiv merged commit 5eb4197 into master Nov 4, 2020
@itamargiv itamargiv deleted the alphaLookupAndMessageRelease branch November 4, 2020 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants