This repository was archived by the owner on May 1, 2025. It is now read-only.
Use netlify for branch hosting the docs storybook#325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finally brings back branch hosting for the composed (tokens+docs+vue-components) storybook 🎉
I haven't found a good way/place to show the netlify link. I added a "Print deploy URL" step in the
deployjob, which may be good enough for now?netlify-cliadvertises an--aliasflag for predictable deployment URLs which looks like a good option to create deployments on a per-branch instead of a per-commit basis so that it can be permanently attached to a PR, but I didn't want to recreate past problems by building the branch name into the URL.Bug: T261650