Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Fix checkbox's width #359

Merged
Ladsgroup merged 1 commit into from
Jan 22, 2021
Merged

Fix checkbox's width #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vue-components/src/components/Checkbox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ $label: '.wikit-checkbox__label';
align-items: center;

&::before {
width: $wikit-Checkbox-input-size;
Copy link
Copy Markdown
Contributor Author

@sai-san sai-san Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the width and height properties because I understand they're being overridden by the min properties, but please correct me if I'm wrong.

Copy link
Copy Markdown
Contributor

@Ladsgroup Ladsgroup Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. It works as expected.

height: $wikit-Checkbox-input-size;
min-width: $wikit-Checkbox-input-size;
min-height: $wikit-Checkbox-input-size;
box-sizing: border-box;

border-width: $wikit-Checkbox-input-border-width;
Expand Down