Create bouncingDots Loader Component#391
Conversation
|
|
||
| basic.argTypes = { | ||
| position: { | ||
| control: { |
There was a problem hiding this comment.
we can remove the controls, since both sizes are visible within the same story
There was a problem hiding this comment.
This configuration can then be replaced with something like there:
wikit/vue-components/stories/QuantityInput.stories.ts
Lines 199 to 201 in 65074e8
See also https://storybook.js.org/docs/react/essentials/controls#hide-nocontrols-warning
(and the entire page might be of interest in general)
There was a problem hiding this comment.
@SaiSan-WMDE thank you for the update
@micgro42 thanks for the resource
| title: '/Loader/BouncingDots', | ||
| }; | ||
|
|
||
| export function basic( args: { content: string; underlined: boolean } ): Component { |
There was a problem hiding this comment.
I believe this story can be called "All", since it contains all size variants
There was a problem hiding this comment.
And since this is supposed to not contain controls, we con drop the args parameter and every place where it is used.
There was a problem hiding this comment.
removed unnecessary args parameter
| @@ -0,0 +1 @@ | |||
| export const bouncingDotsSizes = [ 'small', 'medium' ]; | |||
There was a problem hiding this comment.
It might be that things get confused by having the same filename that differs only by extension and capitalization. Better to rename this file to bouncingDotsProps.ts or something like that
There was a problem hiding this comment.
yea makes sense to change the name
Co-authored-by: Sai_San <sarai.sanchez@wikimedia.de>
- removed unnecessary control from the stroy
bereket-WMDE
force-pushed
the
create_bouncingDots_loader
branch
from
a8b8cae to
33a82ca
Compare
3 participants
Bug: T267010