This repository was archived by the owner on May 1, 2025. It is now read-only.
Add missing typographic style: ui-text#433
Closed
sai-san wants to merge 4 commits into
Closed
Conversation
This introduces the new and much needed ui-text style and conveninetly applies it to the components that should use it.
sai-san
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Body typography is devised to style denser chunks of text (e.g. messages, dialog content, paragraphs) and its style (bigger line-height) is optimized to improve readability in those contexts. On the other hand, labels have a specific meaning in information architecture: these are text components that aim at communicating information in a concise and efficient way that takes the least possible amount of space in a UI.
Neither the body style nor the label nomenclature apply to the text within components: UI text tries to be the default style that covers those instances in which a component could contain (potentially) a bigger amount of text (e.g. inline messages, user input in a text area or table content).
This PR introduces the new ui-text typographic style, and conveniently applies it to the components that currently need it, such as validation messages and input. This approach/exploration needs to be validated wit help from other designers: the PR will remain as a draft until a decision is reached.