This repository was archived by the owner on May 1, 2025. It is now read-only.
ci: run on pull requests#439
Merged
Merged
Conversation
Run CI on pull requests, including external ones. To avoid double CI runs, this means we no longer run CI on pushes, except to the master branch (after a pull request was merged). The deploy job is skipped on external pull requests, since the secrets won’t be available; this should cause the browser-tests job to be skipped as well. Bug: T283911
Ladsgroup
approved these changes
Jul 1, 2021
micgro42
reviewed
Jul 8, 2021
| deploy: | ||
| runs-on: ubuntu-latest | ||
| needs: setup | ||
| if: ${{ github.repository_owner == 'wikit' }} |
Collaborator
There was a problem hiding this comment.
I think this broke our CI. It should have run in #443, but it didn't.
Member
Author
There was a problem hiding this comment.
Wait, shouldn’t this be wmde? wikit is the repository name, not owner.
Merged
micgro42
reviewed
Jul 21, 2021
| push: | ||
| branches: | ||
| - master | ||
| pull_request: |
Collaborator
There was a problem hiding this comment.
I'm not entirely sure yet, but I suspect this has also somehow effectively broken the Netlify link that is commented into the PRs. I suspect that now github.ref in --alias $(echo '${{ github.ref }}' | shasum | awk '{print $1}') in the deploy step below refers no longer to the branch name but to something like refs/pull/439/merge.
I haven't looked closer into how to fix this yet. Might do so tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run CI on pull requests, including external ones. To avoid double CI runs, this means we no longer run CI on pushes, except to the master branch (after a pull request was merged). The deploy job is skipped on external pull requests, since the secrets won’t be available; this should cause the browser-tests job to be skipped as well.
Bug: T283911