This repository was archived by the owner on May 1, 2025. It is now read-only.
Text Area: update Input component tokens#456
Merged
Conversation
sai-san
changed the title
sai-san
commented
Aug 20, 2021
| } | ||
| } | ||
| }, | ||
| "readOnly": { |
Contributor
Author
There was a problem hiding this comment.
Please note that read-only fields present a different background color and limited interaction (user cannot modify their value). Still, they can be activated (focused) and hovered, and thus they should display the border styles corresponding to those states.
sai-san
commented
Aug 20, 2021
sai-san
commented
Aug 20, 2021
This deletes the unnecessary text area tokens and adds the missing readOnly style to the Input tokens
sai-san
changed the title
sai-san
commented
Aug 23, 2021
| "value": "{color.base.30.value}" | ||
| } | ||
| }, | ||
| "field": { |
Contributor
Author
There was a problem hiding this comment.
Mental note: I don't think these are proper alias tokens. A general restructuring and renaming of Alias tokens is a must. To whoever is reading this: no worries, components won't be affected 😎
itamargiv
approved these changes
Sep 2, 2021
Member
itamargiv
left a comment
itamargiv
left a comment
There was a problem hiding this comment.
Cool beans tried it out and it looked good to me 😎 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes available the missing "read only" state in the input component tokens.
IMPORTANT: Text area and input should be visually aligned. That's why input tokens can be used to style this component.
Issue: T289057