Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Add box-shadow page to Storybook#48

Merged
wiese merged 1 commit into
masterfrom
demo-shadows
Jul 3, 2020
Merged

Add box-shadow page to Storybook#48
wiese merged 1 commit into
masterfrom
demo-shadows

Conversation

@tzhelyazkova
Copy link
Copy Markdown
Contributor

@tzhelyazkova tzhelyazkova commented Jul 3, 2020 •
edited by wiese
Loading

Bug: T256858

@tzhelyazkova tzhelyazkova requested review from jakobw and wiese July 3, 2020 13:07
wiese
wiese suggested changes Jul 3, 2020
View reviewed changes
Comment thread docs/src/12-shadows.stories.mdx Outdated
import { Meta, Typeset } from '@storybook/addon-docs/blocks';
import { TokenTable } from './lib/TokenTable';
import * as tokens from '@wmde/wikit-tokens';
import styles from './styles/transition.css';
Copy link
Copy Markdown
Contributor

@wiese wiese Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import styles from './styles/transition.css';

Alternatively, move the many styles from the component into a file made for that purpose (except for the boxShadow, obviously).

@wiese wiese merged commit 16e9b07 into master Jul 3, 2020
@wiese wiese deleted the demo-shadows branch July 3, 2020 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobw jakobw Awaiting requested review from jakobw

1 more reviewer

@wiese wiese wiese approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tzhelyazkova @wiese