Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Port dialog component from mismatch finder#506

Merged
Silvan-WMDE merged 7 commits intomasterfrom
components/dialog/port-from-mismatch-finder
Nov 26, 2021
Merged

Port dialog component from mismatch finder#506
Silvan-WMDE merged 7 commits intomasterfrom
components/dialog/port-from-mismatch-finder

Conversation

@Silvan-WMDE
Copy link
Copy Markdown
Member

@Silvan-WMDE Silvan-WMDE commented Nov 24, 2021

This moves the Dialog component and corresponding tests to WiKit and adapts tokens and styles.

Bug: T295874

@github-actions
Copy link
Copy Markdown

@Silvan-WMDE Silvan-WMDE changed the base branch from master to dialog-tokens-fixes November 25, 2021 14:02
@Silvan-WMDE Silvan-WMDE force-pushed the components/dialog/port-from-mismatch-finder branch from dae90d0 to 60a5f6b Compare November 25, 2021 14:05
@Silvan-WMDE Silvan-WMDE marked this pull request as ready for review November 25, 2021 14:06
@Silvan-WMDE Silvan-WMDE changed the title [WIP] Port dialog component from mismatch finder Port dialog component from mismatch finder Nov 25, 2021
@Silvan-WMDE Silvan-WMDE force-pushed the components/dialog/port-from-mismatch-finder branch from 60a5f6b to a101c59 Compare November 25, 2021 14:15
Copy link
Copy Markdown
Contributor

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can I say! It looks great!

Base automatically changed from dialog-tokens-fixes to master November 25, 2021 17:35
@sai-san
Copy link
Copy Markdown
Contributor

sai-san commented Nov 25, 2021

PR #500 merged 👍

@Silvan-WMDE Silvan-WMDE merged commit c30bbe4 into master Nov 26, 2021
@Silvan-WMDE Silvan-WMDE deleted the components/dialog/port-from-mismatch-finder branch November 26, 2021 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants