This repository was archived by the owner on May 1, 2025. It is now read-only.
Dialog fixes#508
Merged
Merged
Conversation
Contributor
|
Listing the needed fixes here:
|
9509244 to
1938a8b
Compare
1938a8b to
aca8466
Compare
guergana
commented
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes several issues with the Dialog component, and it's story:
The Dialog overlay did not cover the whole viewport/iframe - This was due to some copying and pasting error where the positioning of the dialog within the viewport was reverted from 50%, 50% (x, y) to 0, 0; and a transform was introduced to try and compensate for it. To fix, the transform was removed and the original positioning values restored.
The Scrollbars were not restored in storybook, while navigating from the dialog story when the dialog was still open - This was actually two separate issues:
A. The dialog itself did not complete the hiding animation, and thus the
_restoreScrollmethod was not called. This was mitigated by adding a direct call to_restoreScrollto thebeforeDestroylifecycle hook.B. Storybook does not destroy vue components when switching from the canvas tab to the docs tab (see filed bug on storybook). While this wasn't fixed, this was worked around by ensuring the scrolling is only trapped and restored when the window actually has scrollbars.
The Icon for the close button was replaced.
Additionally, minor fixes included in this change are: passing the correct boolean type (instead of string) as the dialog's
dismiss-buttonprop, and changing the dialog's viewport height from a fixed height (which caused the docs tab to add extra space to the component), to a max-height.Bug: T297093