This repository was archived by the owner on May 1, 2025. It is now read-only.
Cherry pick "Wrap button :focus, :hover and :active styles in :enabled (#584)"#588
Merged
lucaswerkmeister merged 1 commit intonextfrom May 24, 2022
Merged
Cherry pick "Wrap button :focus, :hover and :active styles in :enabled (#584)"#588lucaswerkmeister merged 1 commit intonextfrom
lucaswerkmeister merged 1 commit intonextfrom
Conversation
#584)" Firefox allows a button to be :disabled and still have :focus, if it was programmatically disabled while focused. In this case, the :focus styles would beat the :disabled styles, since they have higher specificity; we want disabled buttons to always look disabled, though, so wrap all the other styles in :enabled so they only apply when wanted. The stylelint rule max-nesting-depth (max depth: 3), which complains about the change, is disabled – the alternative solutions (combining selectors together) seem worse to us in this case. Bug: T304511
Member
Author
|
Cherry-picks #584. |
micgro42
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox allows a button to be :disabled and still have :focus, if it was
programmatically disabled while focused. In this case, the :focus styles
would beat the :disabled styles, since they have higher specificity; we
want disabled buttons to always look disabled, though, so wrap all the
other styles in :enabled so they only apply when wanted.
The stylelint rule max-nesting-depth (max depth: 3), which complains
about the change, is disabled – the alternative solutions (combining
selectors together) seem worse to us in this case.
Bug: T304511