fix: publish workflow draft job failure#2
Open
google-labs-jules[bot] wants to merge 6 commits intomainfrom
Open
fix: publish workflow draft job failure#2google-labs-jules[bot] wants to merge 6 commits intomainfrom
google-labs-jules[bot] wants to merge 6 commits intomainfrom
Conversation
…4245828902254 Add Chinese Localization Support
…erencing condition. Here are the details of the changes: - Removed the `if` condition on the `Create tag` step that referenced its own output, which caused the failure. - Added conditional execution for subsequent release steps (`Create draft CN release`, `Create draft GH release`) to skip them if the tag already exists. - Added conditional execution for `Update Discord interaction` to skip if no new release was created. - Added conditional execution for the final notification job to skip if the release process was skipped.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Removed `if` condition on `Create tag` step that referenced its own output, which is invalid and caused failure. - Added conditional execution for subsequent release steps (`Create draft CN release`, `Create draft GH release`) to skip them if the tag already exists. - Added conditional execution for `Update Discord interaction` to skip if no new release was created. - Added conditional execution for the completion job to skip notification if the release process was skipped. - Validated `pnpm-lock.yaml` is consistent with `package.json`. Resolves conflicts in CI workflow logic. Regarding `pnpm-lock.yaml` conflict: The conflict reported by the user is due to concurrent changes in the upstream repository. To resolve it, the user must merge or rebase with the upstream branch and regenerate the lockfile. This update ensures the local lockfile is consistent but cannot resolve the remote conflict without access to the upstream state.
- Manually resolved conflicts in `package.json`, `apps/web/package.json`, `packages/database/package.json`, and `packages/web-backend/package.json`. - Accepted upstream version (15.5.9) for `next` and related dependencies. - Preserved local `scripts` changes (e.g., `--turbopack` in `apps/web`). - Regenerated `pnpm-lock.yaml` to ensure consistency. - Resolved all other `add/add` conflicts by accepting local changes (`--ours`) to preserve localization work. This commit finalizes the merge of `origin/main` into the current branch, enabling a clean state for further work or CI builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publish.ymlworkflow was failing in thedraftjob because theCreate tagstep had anifcondition referencing its own output (steps.create_tag.outputs.tag_existed), which is not supported and likely caused the step to fail or behave unexpectedly.This change removes the invalid
ifcondition from theCreate tagstep. The script within the step already handles checking for existing tags.To ensure correct behavior when a tag already exists,
ifconditions were added to the subsequent steps (Create draft CN release,Create draft GH release) to prevent them from running if the tag was not created (i.e., it already existed). TheUpdate Discord interactionstep and thedonejob were also updated to skip execution in this scenario, ensuring that notifications are only sent when a new release is actually drafted.PR created automatically by Jules for task 10463511291882609450 started by @wmsir