Merged
Conversation
JisuAhn13
approved these changes
May 19, 2025
|
|
||
| void TestShell::Script1() { | ||
| for (int loopCnt = 0; loopCnt < Script1_TotalLoopCount; ++loopCnt) { | ||
| for (int iter = 0; iter < Script1_OnceLoopCount; ++iter) { |
Collaborator
There was a problem hiding this comment.
기존에도 깔끔했는데 더 가독성이 높게 수정된 것 같네요~! 👍
Collaborator
There was a problem hiding this comment.
함수에 대한 짦은 설명이 있다면 더 좋을 것 같아요~!
MK-Son
approved these changes
May 19, 2025
Collaborator
MK-Son
left a comment
MK-Son
left a comment
There was a problem hiding this comment.
까다로운 시나리오 이네요, 구현하느라 고생하셨습니다!
| command_param.push_back(writevalue); | ||
| write(command_param); | ||
| void TestShell::writeFive(int loopCnt){ | ||
| for (int iter = 0; iter < Script1_OnceLoopCount; ++iter) { |
Collaborator
There was a problem hiding this comment.
OnceLoopCount와 loopCnt 변수 명이 조금 혼란스러운것 같습니다
조금 더 직관적인 아이디어를 강구해봐야겠네요! ㅠ
Owner
Author
There was a problem hiding this comment.
그러니까요.. 추후에 좀더 가독성있는 코드로 변경이 필요해 보입니다 ㅠㅠ
| unsigned int expectedValue = ScriptTest_Value + loopCnt; | ||
|
|
||
| std::vector<unsigned int> readAddress{ address }; | ||
| unsigned int actualValue = read(readAddress); |
Collaborator
There was a problem hiding this comment.
TestShell에서 구현해둔 read/write 메서드를 바로 사용하려고 하니, vector로 다시 넣어야 하는 단점이 있긴하네요,
리펙토링 때 집당지성으로 아이디어 논의 후 개선 하면 좋을것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 개요,
제공된 시나리오에 맞춰 구현 내용 변경
✅ 작업 내용
기존 5번 실행시 write -> read 진행했는데
5개 write 이후 5개 read하는 형식으로 변경
Issue Link #3