Fix CVE gate hard-failing on baseline runs#55
Merged
Conversation
cve-delta.py applied --fail-on even when there was no previous scan to diff against, so any PR adding a brand-new image (no base-branch counterpart) tripped the gate on that image's pre-existing CVEs. A baseline run has no prior state and cannot represent a regression, so report the findings informationally and return 0 instead of exit 2.
Contributor
Trivy misconfiguration findings (HIGH + CRITICAL)✅ No HIGH or CRITICAL misconfigurations detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cve-delta.pyapplied--fail-oneven on a baseline run (no previous scan to diff against). Any PR that adds a brand-new image — which by definition has no base-branch counterpart — had every CVE in that image counted as "introduced," tripping the requiredscancheck.0instead of exit2. Normal delta runs (real regressions) still hard-fail.Test plan
0(was2)2(unchanged)0(unchanged)