Support custom query params in Req.Utils.aws_sigv4_url/1#445
Merged
wojtekmach merged 2 commits intowojtekmach:mainfrom Mar 17, 2025
Merged
Support custom query params in Req.Utils.aws_sigv4_url/1#445wojtekmach merged 2 commits intowojtekmach:mainfrom
wojtekmach merged 2 commits intowojtekmach:mainfrom
Conversation
Contributor
Author
|
@wojtekmach Is this something that makes sense here? If so, anything i can do to help get this merged? |
Owner
|
Sorry for delay I’ll try to get this in next few days. |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #443, S3-compatible APIs support additional query parameters for certain behaviors. One example is to set the response content disposition for file downloads, as motivated by wojtekmach/req_s3#8.
This PR supports arbitrary query parameters passed to
Req.Utils.aws_sigv4_url/1.