Add the clock scale #6
Conversation
src/entry.js
Outdated
| import Clock from './Clock'; | ||
|
|
||
| import './Clock.css'; | ||
| import './Clock.less'; |
There was a problem hiding this comment.
That can't be like that - less is compiled to css on build for compatibility reasons. Not everybody uses less.
src/Mark.jsx
Outdated
| }} | ||
| /> | ||
|
|
||
| {number ? |
There was a problem hiding this comment.
Instead of ternary, you can simply use this syntax: argument && <Component>
src/Clock.jsx
Outdated
| width={hourMarksWidth} | ||
| />, | ||
| ); | ||
| if (this.props.showNumber) { |
There was a problem hiding this comment.
This could be a ternary. No need to duplicate this much code.
<Mark
...
number={this.props.showNumber ? i : null}
...
/>
|
That's super nice! Thanks! |
|
Thanks for your advice. I'll change it and continue to submit it. |
|
Any update on this PR? Excited about the new feature. |
|
Sorry, been super busy lately. @yhlben thanks for contributing and for all the fixes, perfect! |
|
Good deal, thanks man. Are you still pushing updates to the npm package? |
|
Yes, absolutely. 2.3.0 was released with this change, although I changed flag name to |
3 participants
Add the clock scale.Use showNumber prop to show scale.
