samba-libs and dynamic AAD allocation (AES-GCM)#59
Merged
SparkiDev merged 4 commits intowolfSSL:mainfrom Sep 15, 2025
Merged
Conversation
gasbytes
force-pushed
the
samba-libs
branch
21 times, most recently
from
c41488a to
c29f3f6
Compare
gasbytes
force-pushed
the
samba-libs
branch
3 times, most recently
from
8144872 to
ca44a58
Compare
gasbytes
force-pushed
the
samba-libs
branch
3 times, most recently
from
e7762de to
d0d3a55
Compare
gasbytes
force-pushed
the
samba-libs
branch
17 times, most recently
from
8fab15f to
530ee9c
Compare
Kerberos-GCM AAD (~1.8 KiB) overflowed the old 1 KiB cap, triggering GNUTLS_E_SHORT_MEMORY_BUFFER and Samba test failures. 4 KiB unblocks normal traffic; dynamic buffering can follow.
static buffer and transparently spilling to a heap buffer that grows as needed. All GCM paths now use the correct buffer and the heap is freed on context teardown. The test suite is extended with large-AAD cases, including a 128 KiB vector and a 2 K + 4 K + 64 K chunk sequence, to exercise spill and realloc during both encryption and decryption.
gasbytes
force-pushed
the
samba-libs
branch
2 times, most recently
from
b9db986 to
4ab9c62
Compare
gasbytes
force-pushed
the
samba-libs
branch
from
4ab9c62 to
e3ac4d1
Compare
SparkiDev
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.