Fenrir fixes#41
Merged
Merged
Conversation
Fixes F#1863
Fixes F#3730
Fixes F#3943
There was a problem hiding this comment.
Pull request overview
This PR updates the Go wolfSSL bindings and wolftls transport to better support concurrent Read/Write on a single connection (when wolfSSL is built with write-dup support), along with related documentation/test updates and a few example/wrapper correctness fixes.
Changes:
- Add
wolfSSL_write_dup-based split write handle inwolftls.Connand serializewolfSSL_read/wolfSSL_writewith dedicated mutexes (or a shared mutex when write-dup isn’t available). - Update docs/tests to reflect the
--enable-writeduprequirement for true concurrentRead+Write. - Fix/adjust several examples and a wrapper helper (AES-GCM appended-tag encrypt output slicing).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
wolfx509/certgen_wolfcrypt.go |
Removes a custom cgo CFLAG define from the wolfx509 certgen binding build flags. |
wolftls/tls_test.go |
Skips the concurrent Read/Write test when write-dup support isn’t present. |
wolftls/README.md |
Documents --enable-writedup as a build requirement for concurrent Conn Read/Write. |
wolftls/conn.go |
Introduces sslWrite + muRead/muWrite to enable concurrent read/write when supported. |
README.md |
Updates wolfSSL build instructions to include --enable-writedup (currently presented as required). |
examples/x509/extractKey.go |
Adds WolfSSL_Init() and WolfSSL_Cleanup() calls around the example. |
examples/x509/certVerify.go |
Adds WolfSSL_Init() and WolfSSL_Cleanup() calls around the example. |
examples/server/server.go |
Exits on Accept() error to avoid continuing with an invalid connection. |
examples/server/server-psk.go |
Exits on Accept() error to avoid continuing with an invalid connection. |
aes.go |
Ensures the output slice length matches plaintext+tag size in appended-tag GCM encrypt. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes F#3942
Fixes F#4399
Fixes F#4400
Fixes F#4401
lealem47
approved these changes
May 27, 2026
Contributor
lealem47
left a comment
There was a problem hiding this comment.
Thank you @mattia-moffa !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1861, 1863, 3020, 3730, 3942, 3943, 4399, 4400, 4401