Fix some issues related to using FIPs kernel module and userland configurations#159
Merged
LinuxJedi merged 7 commits intowolfSSL:masterfrom Mar 4, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Yocto layer’s wolfSSL FIPS recipes to improve Linux kernel module FIPS hash handling (including an “auto” mode build path) and align some userland/kernel build configuration options.
Changes:
- Adjust wolfSSL FIPS (userland + linuxkm) configure flags (smallstack / SP math options).
- Add an
auto-modedo_compile()path for the linuxkm FIPS recipe to compute/embed the module’s FIPS hash via a dedicated make target. - Introduce a Yocto-series-selected include for linuxkm module signing, with a
scarthgap“modern” implementation, and document linuxkm hash settings in the sample config.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-wolfssl/wolfssl/wolfssl-linuxkm-fips.bb | Adds linuxkm do_compile() logic for auto FIPS hash embedding; updates configure flags. |
| recipes-wolfssl/wolfssl/wolfssl-fips.bb | Updates userland FIPS configure flags. |
| inc/wolfssl-linuxkm/wolfssl-linuxkm-sign-module.inc | Adds Yocto-series-based include selection for signing behavior. |
| inc/wolfssl-linuxkm/scarthgap/wolfssl-linuxkm-sign-module-modern.inc | Adds scarthgap “modern” compile/install logic for signed kernel module output. |
| conf/wolfssl-fips.conf.sample | Documents linuxkm-specific FIPS hash mode and hash variable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
LinuxJedi
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.