Open
Conversation
kareem-wolfssl
added a commit
to kareem-wolfssl/wolfssl
that referenced
this pull request
Mar 5, 2026
Requires wolfSSL/osp#325. Fixes wolfSSL/osp#218.
There was a problem hiding this comment.
Pull request overview
Adds Hitch 1.8.0 patch support for building against wolfSSL, removing the need for OCSP function patching by introducing a --with-wolfssl configure path.
Changes:
- Adds
--with-wolfssloption and wolfSSL/OpenSSL conditional configuration inconfigure.ac. - Disables OpenSSL ENGINE initialization when building with wolfSSL.
- Updates certificate TLV buffer type to
BUF_MEM.
Comments suppressed due to low confidence (2)
hitch/hitch_1.8.0.patch:1
- The
AC_ARG_WITH([wolfssl], ...)handler never assignswith_wolfsslwhen the option is provided, sowith_wolfsslcan be empty and still satisfytest \"$with_wolfssl\" != no. This also mis-handles--with-wolfssl=no(it will setwolfssl_path=noand still enter the wolfSSL branch). Assignwith_wolfssl=$withvalin the option handler (and normalizeno|yes|<path>), then key the conditional off the normalized value.
commit 7afa1dc73a768423ec5d3823e62a58c6d0bd4aeb
hitch/hitch_1.8.0.patch:1
- The wolfSSL branch unconditionally defines feature macros (including
HAVE_TLS_1_3) without any configure-time verification. This can silently misconfigure builds if wolfSSL is compiled without certain features/APIs. Prefer usingHITCH_CHECK_FUNC/AC_CHECK_FUNCS(or a version/feature check viapkg-config --modversion wolfssl) to conditionally define these macros based on actual availability.
commit 7afa1dc73a768423ec5d3823e62a58c6d0bd4aeb
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
julek-wolfssl
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update hitch support for 1.8.0.
wolfSSL has added all of the OCSP functions hitch is using, so no need to patch the OCSP functions anymore.
Requires wolfSSL/wolfssl#9897.