Conversation
dgarske
approved these changes
Oct 11, 2019
Member
dgarske
left a comment
There was a problem hiding this comment.
Thanks Daniele! Excellent feature addition... make config.
danielinux
pushed a commit
that referenced
this pull request
Apr 16, 2024
Fix for test_wrap_unwrap_key handle leak. Add GitHub CI action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this feature is to introduce a new configuration layer, on top of the existing Makefile environment.
include/target.hand the linker scripts for wolfboot and the test application are now automatically generated at compile time according to the global configuration options for the flash geometry.An optional
.configfile can now be provided to alter the default options. Custommakeinvocation that alter the environment still have priority on the values stored in.config.A new target
make configshows an interactive prompt to create a (complete) custom .config file.A few
.configfile usage examples are provided underconfig/examplestest.mkhas been updated accordingly, all test passing on the CI testbed.Ready for review.