Improvement to keystore and key management tools #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danielinux
commented
Sep 28, 2023
danielinux
commented
- sign: added an option to disable timestamp.
- keygen: added options to host multiple keys with different algorithms and sizes
- keygen: added "--id {list}" option to limit permissions for specific keys
danielinux
force-pushed
the
universal_keystore
branch
2 times, most recently
from
995e971 to
4be535d
Compare
For tests with reproducible payload across build
- Allows keys with different algorithms and sizes to be imported/generated - Skips check for keys matching type/length in keystore
danielinux
force-pushed
the
universal_keystore
branch
from
4be535d to
eba3f65
Compare
dgarske
previously approved these changes
Sep 28, 2023
.github/workflows/test-keytools.yml
Outdated
| ./tools/keytools/sign --rsa2048 --sha256 --manual-sign test-app/image.elf public-key.der 1 test-app/image_v1.sig | ||
| # TODO: Test WOLFBOOT_UNIVERSAL_KEYSTORE |
Contributor
There was a problem hiding this comment.
Do you want to add these tests now or future PR?
Member
Author
There was a problem hiding this comment.
good idea, I'll add them now
danielinux
force-pushed
the
universal_keystore
branch
from
8495f90 to
d45b369
Compare
danielinux
force-pushed
the
universal_keystore
branch
from
d45b369 to
dd8fb02
Compare
dgarske
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.