Skip to content

fix warnings for clang build with xmss support #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 1 commit into from
Jan 24, 2025
Merged

fix warnings for clang build with xmss support #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/genkey/clu_genkey_setup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ int wolfCLU_genKeySetup(int argc, char** argv)
int directiveArg = PRIV_AND_PUB_FILES;
char xmssmtParam[XMSSMT_NAME_MAX_LEN + 1]; /* XMSS^MT parameter */
char xmssmtParamHead[] = "XMSSMT-SHA2_\0";
const int xmssmtHeadLen = XSTRLEN(xmssmtParamHead);
const int xmssmtHeadLen = (int)XSTRLEN(xmssmtParamHead);
int height = 0;
const int XMSSMT_MIN_HEIGHT = 20;
const int hdLen = 9;
Expand Down Expand Up @@ -511,7 +511,7 @@ int wolfCLU_genKeySetup(int argc, char** argv)
int directiveArg = PRIV_AND_PUB_FILES;
char xmssParam[XMSS_NAME_LEN + 1]; /* XMSS parameter */
char xmssParamHead[] = "XMSS-SHA2_";
int xmssHeadLen = XSTRLEN(xmssParamHead);
int xmssHeadLen = (int)XSTRLEN(xmssParamHead);
const int hLen = 6;

WOLFCLU_LOG(WOLFCLU_L0, "Generate XMSS Key");
Expand Down
8 changes: 6 additions & 2 deletions src/sign-verify/clu_sign.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,9 +902,13 @@ int wolfCLU_sign_data_xmssmt(byte* data, char* out, int fSz, char* privKey)
word32 outBufSz = 0; /* signature buffer size */
char* paramStr = NULL; /* parameter string */
int paramLen = 0; /* parameter string length */
int privKeyLen = XSTRLEN(privKey); /* private key file name length */
int privKeyLen = 0; /* private key file name length */
int fileHeadLen = 7; /* file header(XMSSMT-) length */

if (privKey == NULL) {
return BAD_FUNC_ARG;
}
privKeyLen = (int)XSTRLEN(privKey);
#ifdef WOLFSSL_SMALL_STACK
XmssKey *key = (XmssKey*)XMALLOC(sizeof(XmssKey),
HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
Expand Down Expand Up @@ -974,7 +978,7 @@ int wolfCLU_sign_data_xmssmt(byte* data, char* out, int fSz, char* privKey)
XMEMSET(paramStr, 0, paramLen);
XSTRNCPY(paramStr, privKey, paramLen);
paramStr[paramLen - 1] = '\0';
/*
/*
* replace from '-' to '/' such as
* from "XMSSMT-SHA2_20-2_256" to "XMSSMT-SHA2_20/2_256"
*/
Expand Down