additional sanity checks on arguments from static analysis tests#222
additional sanity checks on arguments from static analysis tests#222lealem47 merged 3 commits intowolfSSL:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds additional sanity checks and regression tests around CLI argument handling and I/O behaviors, while hardening a few code paths flagged by static analysis (NULL checks and safer pointer usage).
Changes:
- Add regression tests for RSA
-pubin/-inform DERround-trip andencwriting ciphertext to stdout when-outis omitted. - Add missing NULL checks around object creation/usage in verify/PKCS7/EVP crypto paths.
- Fix RSA public-key DER parsing to avoid freeing an advanced pointer after
d2idecoding.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/pkey/rsa-test.py | Adds test coverage for RSA public key DER output + modulus printing. |
| tests/encrypt/enc-test.py | Adds test ensuring enc emits ciphertext to stdout when no -out is specified. |
| src/sign-verify/clu_x509_verify.c | Guards intermediate stack push behind successful stack creation. |
| src/sign-verify/clu_crl_verify.c | Adds NULL check after wolfSSL_CertManagerNew() before using it. |
| src/pkey/clu_rsa.c | Uses a separate parse pointer for d2i to keep the base pointer valid for XFREE. |
| src/pkcs/clu_pkcs7.c | Checks for NULL return from wolfSSL_BIO_new() before calling wolfSSL_BIO_set_fp(). |
| src/crypto/clu_evp_crypto.c | Avoids calling wolfSSL_BIO_set_fp() when BIO allocation fails. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #222
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
No description provided.