Call wolfCrypt_SetCb_fips in wolfengine_bind for FIPS builds. #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
reviewed
Feb 1, 2022
src/we_internal.c
Outdated
| WOLFENGINE_ENTER(WE_LOG_ENGINE, "wolfengine_bind"); | ||
|
|
||
| #ifdef HAVE_FIPS | ||
| wolfCrypt_SetCb_fips(fipsCb); |
Contributor
There was a problem hiding this comment.
Need to include fips_test.h?
anhu
reviewed
Feb 1, 2022
src/we_internal.c
Outdated
| printf("hash = %s\n", hash); | ||
|
|
||
| if (err == IN_CORE_FIPS_E) { | ||
| printf("In core integrity hash check failure. Copy above hash\n"); |
Member
There was a problem hiding this comment.
I think the initial "In" seems weird. I think it should be
Core integrity hash check failure. Copy above hash....
src/we_internal.c
Outdated
| printf("hash = %s\n", hash); | ||
|
|
||
| if (err == IN_CORE_FIPS_E) { | ||
| printf("In core integrity hash check failure. Copy above hash\n"); |
Member
There was a problem hiding this comment.
I think this should have more markers to make it more prominent. like
printf("*******************************************\n");
We've had a lot of users come to us for support when wolfEngine can't be found, and the resolution often ends up being that the FIPS module integrity check failed and the expected HMAC value needs to be updated. This commit sets up a callback that will indicate the problem and how to fix it, just like we do for testwolfcrypt in wolfSSL.
SparkiDev
approved these changes
Feb 2, 2022
anhu
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a lot of users come to us for support when wolfEngine can't be found,
and the resolution often ends up being that the FIPS module integrity check
failed and the expected HMAC value needs to be updated. This commit sets up
a callback that will indicate the problem and how to fix it, just like we do
for testwolfcrypt in wolfSSL.