Fix transposed copy size and buffer offset in wh_FlashUnit_ReadBytes#295
Merged
bigbrett merged 1 commit intowolfSSL:mainfrom Mar 10, 2026
Merged
Fix transposed copy size and buffer offset in wh_FlashUnit_ReadBytes#295bigbrett merged 1 commit intowolfSSL:mainfrom
bigbrett merged 1 commit intowolfSSL:mainfrom
Conversation
The unaligned read path swapped the copy length and buffer index: this_size was set to offset_rem instead of (WHFU_BYTES_PER_UNIT - offset_rem), and the memcpy source used the inverse. This corrupted data on every unaligned read where offset_rem != WHFU_BYTES_PER_UNIT/2. Added test cases for unaligned ReadBytes with offset_rem = 1, 2, 3, and 5, including a multi-phase read spanning leading partial, aligned middle, and trailing partial units. Signed-off-by: Sameeh Jubran <sameeh@wolfssl.com>
bigbrett
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unaligned read path swapped the copy length and buffer index: this_size was set to offset_rem instead of (WHFU_BYTES_PER_UNIT - offset_rem), and the memcpy source used the inverse. This corrupted data on every unaligned read where offset_rem != WHFU_BYTES_PER_UNIT/2.
Added test cases for unaligned ReadBytes with offset_rem = 1, 2, 3, and 5, including a multi-phase read spanning leading partial, aligned middle, and trailing partial units.