Merged
Conversation
Change NetRead and NetWrite to loop internally until the entire transfer completes rather than returning MQTT_CODE_CONTINUE for partial transfers. This reduces round-trips and prevents timeout issues while still correctly handling partial data. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dgarske
approved these changes
Feb 4, 2026
philljj
approved these changes
Feb 4, 2026
Contributor
philljj
left a comment
philljj
left a comment
There was a problem hiding this comment.
Looks good! Definitely an improvement over the original implementation.
Tiny suggestion but not mandatory: check if sock->bytes > buf_len or similar, in case curl_easy_send/recv sets something nonsense to size_t * n.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MQTT_CODE_CONTINUE for each partial transfer