Fixes in MQTT-SN code found by Fenrir#468
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a single-character bug in the MQTT-SN SN_Encode_RegAck function where the return code field was being incorrectly written into the transmit buffer using += (addition assignment) instead of = (simple assignment), which would corrupt the encoded packet by adding the return code value to whatever byte was previously at that memory location.
Changes:
- Fixed
*tx_payload += regack->return_code→*tx_payload = regack->return_codeinSN_Encode_RegAck
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.