Fixes to reduce the size of heap use for PKCS11 objects. #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinuxJedi
force-pushed
the
object_heap
branch
2 times, most recently
from
3569b3e to
0168971
Compare
We need to allocate the key information after we know whether or not the object is a key.
LinuxJedi
changed the title
dgarske
approved these changes
Aug 1, 2025
Collaborator
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Approved! ./tests/pkcs11test peak heap: 67712 -> 45056 bytes. For objects that are not keys the allocated memory for an object is greatly reduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key information for an object is now allocated on demand, instead of allocated as part of the object creation regardless of whether it was used.
Also contains a fix for debug function visibility.