Sample app#14
Merged
douzzer merged 22 commits intowolfSSL:masterfrom Dec 29, 2023
Merged
Conversation
added 15 commits
December 26, 2023 13:25
In recent versions (>v5.5.0) of wolfSSL, WOLFSSL_PSS_LONG_SALT is enabled by default
Contributor
Author
|
retest this please |
Closed
douzzer
requested changes
Dec 28, 2023
Contributor
Author
|
retest this please |
douzzer
approved these changes
Dec 29, 2023
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
LGTM, modulo the lower-priority carps from shellcheck, which you can address at your leisure.
Note that the canonical way to test if a process is running is kill -0 $pid (shell built-in), which you can use to streamline check_process_running(), or just refactor it out completely using kill -0 inline in the conditionals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.