Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds CI testing support for liboauth2 by introducing a new GitHub Actions workflow and extending the result-checking script.
- Introduces
.github/workflows/liboauth2.ymlto run liboauth2 tests against multiple dependencies - Extends
.github/scripts/check-workflow-result.shto validate liboauth2 test outcomes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/liboauth2.yml | New workflow to build dependencies and run tests |
| .github/scripts/check-workflow-result.sh | Added logic to parse liboauth2 test results |
Comments suppressed due to low confidence (2)
.github/workflows/liboauth2.yml:37
- [nitpick] The step name suggests checking out the wolfProvider repo but actually uses the default checkout for this repo. Rename to clarify that this is the main repo checkout or specify
path:if targeting a different repo.
- name: Checkout wolfProvider
.github/scripts/check-workflow-result.sh:246
- The force-fail condition is compared earlier against the literal string
WOLFPROV_FORCE_FAIL=1, butWOLFPROV_FORCE_FAILis likely set to1. Update the comparison toif [ "$WOLFPROV_FORCE_FAIL" = "1" ]or normalize $2 before comparing.
elif [ "$TEST_SUITE" = "liboauth2" ]; then
ColtonWilley
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for liboath2 CI testing with
WPFFnewest refs and utilizesbuild-wolfprovider.yml