Skip to content

liboauth2 CI test support#157

Merged
ColtonWilley merged 5 commits intowolfSSL:masterfrom
aidangarske:liboauth2-workflow
Jun 9, 2025
Merged

liboauth2 CI test support#157
ColtonWilley merged 5 commits intowolfSSL:masterfrom
aidangarske:liboauth2-workflow

Conversation

@aidangarske
Copy link
Copy Markdown
Member

Adds support for liboath2 CI testing with WPFF newest refs and utilizes build-wolfprovider.yml

@aidangarske aidangarske self-assigned this Jun 5, 2025
@aidangarske aidangarske marked this pull request as ready for review June 6, 2025 15:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds CI testing support for liboauth2 by introducing a new GitHub Actions workflow and extending the result-checking script.

  • Introduces .github/workflows/liboauth2.yml to run liboauth2 tests against multiple dependencies
  • Extends .github/scripts/check-workflow-result.sh to validate liboauth2 test outcomes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/liboauth2.yml New workflow to build dependencies and run tests
.github/scripts/check-workflow-result.sh Added logic to parse liboauth2 test results
Comments suppressed due to low confidence (2)

.github/workflows/liboauth2.yml:37

  • [nitpick] The step name suggests checking out the wolfProvider repo but actually uses the default checkout for this repo. Rename to clarify that this is the main repo checkout or specify path: if targeting a different repo.
- name: Checkout wolfProvider

.github/scripts/check-workflow-result.sh:246

  • The force-fail condition is compared earlier against the literal string WOLFPROV_FORCE_FAIL=1, but WOLFPROV_FORCE_FAIL is likely set to 1. Update the comparison to if [ "$WOLFPROV_FORCE_FAIL" = "1" ] or normalize $2 before comparing.
elif [ "$TEST_SUITE" = "liboauth2" ]; then

@ColtonWilley ColtonWilley merged commit d2cba6d into wolfSSL:master Jun 9, 2025
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants