Fix fenrir wolfTPM findings (3)#470
Merged
dgarske merged 3 commits intowolfSSL:masterfrom Mar 17, 2026
Merged
Conversation
…#544, #545, #546, #547, #878, #879, #880, #883, #884, #885, #886
There was a problem hiding this comment.
Pull request overview
Addresses multiple Fenrir wolfTPM findings by tightening bounds checks, improving input validation, and zeroizing sensitive structures after use.
Changes:
- Add size/NULL validation to prevent buffer overreads/overwrites (key blob parsing, session index checks, NVReadCert, RNG output size validation).
- Add explicit zeroization of sensitive intermediates (RSA/ECC private material, sensitive structs, command inputs).
- Adjust SwTPM send-command return-code initialization.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/tpm2_wrap.c | Adds bounds checks, session index validation, and sensitive memory zeroization in multiple key/crypto paths. |
| src/tpm2_swtpm.c | Changes default return code initialization in SWTPM command send path. |
| src/tpm2.c | Tightens RNG nonce-output size validation to prevent invalid lengths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
requested changes
Mar 16, 2026
dgarske
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Fenrir findings
#342, #536, #537, #538, #541, #542, #543, #544, #545, #546, #547, #878, #879, #880, #883, #884, #885, #886