Move some cdef declarations for RSA to separate section #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definitions for the following functions are not always available
when wolfSSL is configured to only contain a minimum of functionality:
- wc_GetPkcs8TraditionalOffset (only with ASN, which is required for
RSA)
- wc_PemToDer (only when KEYGEN is enabled)
- wc_DerToPemEx (only when KEYGEN is enabled)
This change allows for building the Python wrapper when ASN and RSA
are both disabled.
lealem47
reviewed
Dec 3, 2025
lealem47
requested changes
Dec 3, 2025
Contributor
lealem47
left a comment
lealem47
left a comment
There was a problem hiding this comment.
Just the one comment, the rest of the changes look good
It's part of the ASN feature but since it's also used by the RSA binding this function must also be part of the library when only the RSA feature is selected.
These functions are actually not tied to the KEYGEN feature.
Contributor
Author
|
Testing the various combinations is a little tricky because it isn’t automated. I moved the two keygen functions to the |
lealem47
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definitions for the following functions are not always available when wolfSSL is configured to only contain a minimum of functionality:
This change allows for building the Python wrapper when ASN and RSA are both disabled.