SFTP Speed#488
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Jan 20, 2023
Merged
Conversation
JacobBarthelmeh
approved these changes
Jan 18, 2023
1. Improve the througput of SFTP. Clients will request a particular size chunk of a file at a time. Most clients are flexible with receiving less than requested. But, sending 1kiB at a time requires many times more messages, encryptions, and transmits than when sending a larger block. One particular client requests 32kiB blocks, always, and expects to get 32kiB at a time. This changes the amount buffered to 32kiB. You can change the value smaller, but may have issues with some clients. 2. The loop on SFTP write needs to take into account WANT_READ while trying to write to the client. If it doesn't try again, it'll return and lose part of the data causing other issues.
ejohnstown
force-pushed
the
sftp-speed
branch
from
a07d376 to
bd60193
Compare
JacobBarthelmeh
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the througput of SFTP. Clients will request a particular size chunk of a file at a time. Most clients are flexible with receiving less than requested. But, sending 1kiB at a time requires many times more messages, encryptions, and transmits than when sending a larger block. One particular client requests 32kiB blocks, always, and expects to get 32kiB at a time. This changes the amount buffered to 32kiB. You can change the value smaller, but may have issues with some clients.
Testing using Windows on VmWare as the client and the echoserver running on the macOS host machine.