Skip to content

wolfSSH Client with OpenSSH-format Keys#604

Merged
JacobBarthelmeh merged 9 commits intowolfSSL:masterfrom
ejohnstown:wolfssh-client-2
Nov 17, 2023
Merged

wolfSSH Client with OpenSSH-format Keys#604
JacobBarthelmeh merged 9 commits intowolfSSL:masterfrom
ejohnstown:wolfssh-client-2

Conversation

@ejohnstown
Copy link
Copy Markdown
Contributor

@ejohnstown ejohnstown commented Oct 16, 2023

  1. Move the KeySignature struct around in internal.c so it can be used for a couple tasks.
  2. Add decoder for the OpenSSH-format keys.
  3. Add an identification function for the new key.
  4. Update ReadKey to handle the new format.

@ejohnstown ejohnstown force-pushed the wolfssh-client-2 branch 2 times, most recently from 2a5da5f to ca6c50d Compare October 16, 2023 23:45
JacobBarthelmeh
JacobBarthelmeh requested changes Oct 31, 2023
View reviewed changes
Comment thread src/internal.c Outdated
Comment thread src/internal.c Outdated
Comment thread src/internal.c Outdated
Comment thread src/internal.c Outdated
Comment thread src/internal.c Outdated
Comment thread src/internal.c
Comment thread src/ssh.c
Comment thread src/ssh.c Outdated
Comment thread src/ssh.c Outdated
Comment thread src/ssh.c
JacobBarthelmeh
JacobBarthelmeh requested changes Nov 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Thanks John! Only other thing is I see there is not a test yet. Hoping that we can add one of the keys to the wolfssh/keys directory and a basic test case.

@ejohnstown ejohnstown force-pushed the wolfssh-client-2 branch 3 times, most recently from 97a41f5 to 1c33924 Compare November 6, 2023 21:52
@ejohnstown
wolfSSH Client with OpenSSH-format Keys
70aa287 
1. Move the KeySignature struct around in internal.c so it can be used
   for a couple tasks.
2. Add decoder for the OpenSSH-format keys.
3. Add an identification function for the new key.
4. Update ReadKey to handle the new format.
@ejohnstown
wolfSSH Client with OpenSSH-format Keys
732aba4 
1. Add two error codes for the new key format decoding.
2. Add in some better error and bound checking.
3. Fix ordering on a WOLFSSH_UNUSED and variable declaration.
4. Remove redundant ; from WOLFSSH_UNUSED function-like macro.
@ejohnstown
PR review: Update some std-C functions with the proper porting wrappers.
9bbfcf1
@ejohnstown
PR review: Fix potential memory leak when failing to parse a key of a…
8049606 
…ny type.
@ejohnstown
PR Review
3b443c0 
1. Add better error checking to the OpenSSH key code.
2. Add a couple heaps that were missing.
@ejohnstown
PR Review
23a9bb8 
1. Change the block size in the key decoding to a named constant rather
   than a bare number.
2. Change the comparison from a difference of two unsigned values
   against zero to comparing them directly.
@ejohnstown
PR Review: Remove unused struct members from WS_KeySignature.
707104e
@ejohnstown ejohnstown force-pushed the wolfssh-client-2 branch 2 times, most recently from 66d6c9a to d191292 Compare November 6, 2023 22:19
@ejohnstown
PR Review
dba9a6c 
1. Add test keys.
2. Add API test for wolfSSH_ReadKey_buffer().
3. Fix allocation issue found using the API test.
@ejohnstown ejohnstown removed their assignment Nov 6, 2023
JacobBarthelmeh
JacobBarthelmeh previously approved these changes Nov 7, 2023
View reviewed changes
@ejohnstown
PR Review
ec1964d 
1. Rename and move CleanupUserAuthRequestPublicKey() as
   wolfSSH_KEY_clean().
2. Restrict the number of keys allowed in an OpenSSH key package to 1.
3. Initialize the Rsa and Ecc keys right before getting them.
4. New error code for an OpenSSH key format error when decoding.
@JacobBarthelmeh JacobBarthelmeh merged commit b7aaabc into wolfSSL:master Nov 17, 2023
@ejohnstown ejohnstown deleted the wolfssh-client-2 branch November 17, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh approved these changes

Assignees

@JacobBarthelmeh JacobBarthelmeh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ejohnstown @JacobBarthelmeh