Made setting file modes portable#616
Merged
ejohnstown merged 3 commits intowolfSSL:masterfrom Dec 5, 2023
Merged
Conversation
|
Can one of the admins verify this patch? |
falemagn
force-pushed
the
pull-reqs/make-sftp-setmode-portable
branch
from
b94405b to
7e10cac
Compare
…TP_SETFILEMODE and WOLFSSH_SFTP_SETMODE macros, in which case the functions SFTP_SetMode and SFTP_SetFileMode will have to be externally defined for the platform the library is being ported to.
falemagn
force-pushed
the
pull-reqs/make-sftp-setmode-portable
branch
from
7e10cac to
03f82ab
Compare
Contributor
|
Ok to test |
ejohnstown
requested changes
Nov 17, 2023
ejohnstown
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made setting file modes portable, by means of defining the WOLFSSH_SFTP_SETMODE and WOLFSSH_SFTP_SETMODEHANDLE macros, in which case the functions SFTP_SetMode and SFTP_SetModeHandle will have to be externally defined for the platform the library is being ported to.