Known Hosts#620
Merged
JacobBarthelmeh merged 5 commits intowolfSSL:masterfrom Nov 27, 2023
Merged
Conversation
1. Added support to the wolfSSH client for a known hosts file. 2. In the client's common.c file, moved the functions ato32() and load_der_file() around so the known hosts callback can uses them.
1. Comment out the original known hosts check for another method. 2. Implement new key checking method.
1. Update the logic for checking the key name and key against the known hosts file. 2. Key fingerprinting for user confirmation. 3. Add user confirmation of host key additions. 4. Remove old debugging for known hosts.
1. Add porting layer wrapper macros for strcat, strcpy, and strsep. 2. Use port layer macros for the known hosts additions.
JacobBarthelmeh
requested changes
Nov 22, 2023
1. Fix a few stdC function calls to use the porting wrappers. 2. Missing some error checking, added it. 3. Add some bounds checking to the sz usage when checking for the server's key in the known hosts file. 4. Move the temp buffers from the stack to the heap. 5. Make sure to nul terminate the read known_hosts file.
JacobBarthelmeh
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Known Hosts file checking for the wolfssh application. It currently checks the file "~/.ssh/known_hosts". Reports missing, duplicate, or bad keys.