Merged
Conversation
1. Remove the continue from the SFTP worker loop when there's a timeout on the select and when there's a want_read from the wolfSSH_worker. 2. When the select has receive data ready, check it. Don't make it conditional on want read as well. The goal is that when there isn't data waiting on the socket, check and process the data in the SFTP channel's buffer, always.
JacobBarthelmeh
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal is that when there isn't data waiting on the socket, check and process the data in the SFTP channel's buffer, always.
Testing
From another directory run the SFTP client:
I was able to copy the files configure, configure.ac, README.md, and a 6GB iso image I had floating around.