Key Agree Update#686
Merged
JacobBarthelmeh merged 3 commits intowolfSSL:masterfrom May 13, 2024
Merged
Conversation
1. In the key signature block, add flag for Ecc, and for the key allocation. 2. Add FreePubKey() to delete the pub key stored in the key signature block. 3. In DoKexDhReply(), break down the key agreement actions for the various supported key types into their own functions. Remove the redundant variables. 4. Using flags that are always present, reduce some of the complicated flag checks. 5. Fix a compile guard where the ECDH private key used by the client is disabled by ECDSA.
1. In SendKexDhReply(), break down the key agreement actions for the various supported key types into their own functions. Remove the redundant variables. 2. In DoKexDhInit(), add flags for the various key agreement types, and set them as appropriate when checking the selected kexId. The flags are always present no matter the build options. 3. Simplify some of the flag checks for optional options.
Closed
1. Add a parameter to the client key agree functions for the hashId. It's only really used for EcdhKyber1, but it keeps the functions parallel. 2. Add and update some top-of-function comments for the key agree functions. 3. Renamed the X25519 key agreement functions to Curve25519 to match the naming in the RFC. 4. Removed the temporary hashId local in the client EcdhKyber1 function. 5. Messed around with some variable declarations in a few of the functions. 6. Fix a couple breaks for small stack build. 7. Fix where GEX-SHA2 key exchange wasn't allowed to work. 8. Disable EcdhKyber1 is ECDH-NISTP256 is disabled.
ejohnstown
force-pushed
the
key-agree-update
branch
from
1d1e824 to
6e93b92
Compare
JacobBarthelmeh
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix issue #678 and #679. This supercedes pull request #684.