Skip to content

Kyber Testing#692

Merged
dgarske merged 3 commits intowolfSSL:masterfrom
ejohnstown:kyber-fancy-action
May 16, 2024
Merged

Kyber Testing#692
dgarske merged 3 commits intowolfSSL:masterfrom
ejohnstown:kyber-fancy-action

Conversation

@ejohnstown
Copy link
Copy Markdown
Contributor

Add a workflow for a kyber testing. It's only a make check, but ECDSA+Kyber is the default KEX.

Add a workflow for a kyber test.
Comment thread .github/workflows/kyber.yml Outdated
Comment thread .github/workflows/kyber.yml Outdated
Comment thread .github/workflows/kyber.yml Outdated
Comment thread .github/workflows/kyber.yml Outdated
Comment thread .github/workflows/kyber.yml Outdated
Comment thread .github/workflows/kyber.yml Outdated
@ejohnstown ejohnstown force-pushed the kyber-fancy-action branch 10 times, most recently from 5c251c7 to 06f0f35 Compare May 16, 2024 01:37
1. Updated to use more standard actions.
2. Cache the outputs of the dependencies.
@ejohnstown ejohnstown force-pushed the kyber-fancy-action branch from 06f0f35 to 19e39d9 Compare May 16, 2024 01:52
Copy link
Copy Markdown
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fixes. Almost there.

Comment thread .github/workflows/kyber.yml Outdated
Comment thread .github/workflows/kyber.yml Outdated
Comment thread .github/workflows/kyber.yml Outdated
Comment thread .github/workflows/kyber.yml Outdated
@ejohnstown ejohnstown force-pushed the kyber-fancy-action branch 5 times, most recently from a0ffdca to b7e10f8 Compare May 16, 2024 16:20
1. Switch to using variables for the versions.
2. Updated cache use per recommondations.
3. Renamed the cached items with "kyber" in the name.
@ejohnstown ejohnstown force-pushed the kyber-fancy-action branch from b7e10f8 to 8da722e Compare May 16, 2024 16:21
@ejohnstown ejohnstown requested a review from julek-wolfssl May 16, 2024 16:27
@ejohnstown ejohnstown assigned wolfSSL-Bot and unassigned ejohnstown May 16, 2024
Copy link
Copy Markdown
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@dgarske dgarske merged commit e12e725 into wolfSSL:master May 16, 2024
@ejohnstown ejohnstown deleted the kyber-fancy-action branch May 16, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants