Fixup#735
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Aug 16, 2024
Merged
Conversation
Contributor
ejohnstown
commented
Aug 16, 2024
ejohnstown
commented
- Initialize a local variable DoKexInit() as a compiler complains it is getting used with a garbage value. (Not true, but hushing the compiler.)
- In GetInputText() and GetInputData(), set the error value into ssh->error and just return WS_ERROR.
1. Initialize a local variable DoKexInit() as a compiler complains it is getting used with a garbage value. (Not true, but hushing the compiler.) 2. In GetInputText() add braces around the error check if clauses, and give the version error its own check instead of a ternary return. 3. In GetInputData(), if the recv return was anything else, return a general socket error.
JacobBarthelmeh
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.