Merged
Conversation
The autogen script is doing too many things. The tests that are set up in the git hooks are already tested by GitHub with actions on branch push. Also they don't work if you install wolfSSL somewhere specific. All one needs to do is run `autoreconf -ivf` to make the configure script. This is all autogen does now, with the addition of warnings.
JacobBarthelmeh
approved these changes
Jan 15, 2025
Contributor
|
Confirmed working on WSL. Nice change to simplify things. Thanks @ejohnstown for assistance regarding my error when using that resulted in: Using a fully-qualified path worked: |
gojimmypi
reviewed
Jan 16, 2025
Contributor
gojimmypi
left a comment
gojimmypi
left a comment
There was a problem hiding this comment.
tested and confirmed working on WSL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autogen script is doing too many things. The tests that are set up in the git hooks are already tested by GitHub with actions on branch push. Also they don't work if you install wolfSSL somewhere specific. All one needs to do is run
autoreconf -ivfto make the configure script. This is all autogen does now, with the addition of warnings.