-
Notifications
You must be signed in to change notification settings - Fork 99
Release v1.4.22 #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.4.22 #863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This release addresses NULL pointer and boundary check issues identified by the scan-build static analysis tool, improving code robustness and preventing potential crashes.
- Added NULL pointer checks before memory operations and string comparisons
- Modified string handling functions to avoid unnecessary operations on empty strings
- Refactored error handling to use consistent control flow patterns with cascading checks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b32fd48 to
26d9912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1. When looking up a name in the name-ID map, don't bother checking if the name is NULL. 2. The GetString functions should fail if the destination string parameter is NULL. 3. The GetString functions should not bother to copy an empty string found in the data stream. 4. When checking the public key type provided by the callback, do not check it when it is NULL.
26d9912 to
7f6b5b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Found with scan-build.