Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes wolfSSH_AGENT_Relay() in src/agent.c to correctly check the return value from agentIoCb() (sz) for WS_CBIO_ERR_GENERAL, instead of incorrectly checking ret. This ensures the agent reconnect/setup retry path is triggered when the agent I/O write callback reports a general error.
Changes:
- Update the error-condition check in
wolfSSH_AGENT_Relay()to compareszagainstWS_CBIO_ERR_GENERAL.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes wolfSSH_AGENT_Relay() so that it evaluates the sz instead of ret in line 1734 properly.
This addresses to f_1677.