Skip to content

Add kex integration test for ed25519 server key#924

Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom
yosuke-wolfssl:f_2485
Apr 21, 2026
Merged

Add kex integration test for ed25519 server key#924
ejohnstown merged 1 commit intowolfSSL:masterfrom
yosuke-wolfssl:f_2485

Conversation

@yosuke-wolfssl
Copy link
Copy Markdown
Contributor

This PR adds kex integration test and sample keys for ed25519 use-case.
Also, this updates echoserver to load the ed25519 keys.

@yosuke-wolfssl yosuke-wolfssl self-assigned this Apr 16, 2026
Copilot AI review requested due to automatic review settings April 16, 2026 05:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Ed25519 host-key coverage to the integration KEX test flow by introducing sample Ed25519 server keys and teaching echoserver to load/use them.

Changes:

  • Added an Ed25519 host-key integration test in tests/kex.c.
  • Added Ed25519 server key material (.der / .pem) under keys/.
  • Updated examples/echoserver/echoserver.c (and embedded cert buffers) to load the Ed25519 private key.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
wolfssh/certs_test.h Adds embedded Ed25519 DER key buffer for NO_FILESYSTEM builds.
tests/kex.c Adds Ed25519 host-key test and adjusts test availability macros.
keys/server-key-ed25519.pem Adds sample Ed25519 private key (PEM).
keys/server-key-ed25519.der Adds sample Ed25519 private key (DER).
examples/echoserver/echoserver.c Adds Ed25519 key loading logic and registers it with the server context.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/kex.c Outdated
Comment thread examples/echoserver/echoserver.c Outdated
Comment thread examples/echoserver/echoserver.c
@ejohnstown ejohnstown merged commit 6d09901 into wolfSSL:master Apr 21, 2026
131 checks passed
@yosuke-wolfssl yosuke-wolfssl deleted the f_2485 branch April 21, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants