Fix DoRequestSuccess and DoRequestFailure, Add regress test#949
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom Apr 23, 2026
Merged
Fix DoRequestSuccess and DoRequestFailure, Add regress test#949ejohnstown merged 1 commit intowolfSSL:masterfrom
ejohnstown merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes parsing of SSH_MSG_REQUEST_SUCCESS / SSH_MSG_REQUEST_FAILURE payloads to match RFC 4254 §4 (payload is message-specific data with no length prefix), preventing buffer overruns during packet consumption, and adds a regression test to cover the scenario where the success payload is a raw uint32 port.
Changes:
- Update
DoRequestSuccess()/DoRequestFailure()to advance the payload index bylen(payload size) rather than parsing a length-prefixed field. - Add a regression test that feeds a
SSH_MSG_REQUEST_SUCCESSpacket with auint32port payload and assertsDoReceive()succeeds. - Wire the new regression test into the regress test runner.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/internal.c |
Corrects request success/failure payload consumption logic to avoid interpreting payload data as a length prefix. |
tests/regress.c |
Adds and executes a regression test ensuring SSH_MSG_REQUEST_SUCCESS with a uint32 payload parses successfully. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 4254 §4 defines SSH_MSG_REQUEST_SUCCESS as byte SSH_MSG_REQUEST_SUCCESS followed directly by response-specific data (with no length prefix).
This PR fixes DoRequestSuccess and DoRequestFailure so that these don't consume the data with length prefix.
Also, this adds the regress test.