Fix minor issues and Add unit tests#982
Open
yosuke-wolfssl wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens channel message validation and adds internal unit tests for the new channel handling behavior.
Changes:
- Validates recipient channel IDs for CHANNEL_SUCCESS and CHANNEL_FAILURE.
- Adds max packet size and EOF checks for channel data send/receive paths.
- Suppresses replies for RFC-defined no-reply channel requests and adds unit coverage for several new paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
wolfssh/internal.h |
Exposes additional internal test wrappers under WOLFSSH_TEST_INTERNAL. |
src/internal.c |
Updates channel request/data handling and adds internal wrapper implementations. |
tests/unit.c |
Adds unit tests for channel success/failure, data overflow, and EOF send behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #982
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
Also, this adds new unit tests accordingly.
Addressed by f_866, f_867, f_1690 and f_3447.